Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: fix cppcoreguidelines-prefer-member-initializer #2191

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

yperbasis
Copy link
Member

and also cppcoreguidelines-macro-to-enum

@yperbasis yperbasis added the maintenance Some maintenance work (fix, refactor, rename, test...) label Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 61.76471% with 26 lines in your changes missing coverage. Please review.

Project coverage is 53.52%. Comparing base (5756523) to head (6a40207).

Files Patch % Lines
silkworm/rpc/commands/ots_api.cpp 0.00% 10 Missing ⚠️
silkworm/rpc/commands/ots_api.hpp 0.00% 10 Missing ⚠️
silkworm/sync/messages/inbound_new_block.cpp 0.00% 3 Missing ⚠️
...ilkworm/sync/messages/inbound_new_block_hashes.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2191   +/-   ##
=======================================
  Coverage   53.52%   53.52%           
=======================================
  Files         687      687           
  Lines       47834    47838    +4     
  Branches     7253     7253           
=======================================
+ Hits        25603    25607    +4     
+ Misses      20005    20002    -3     
- Partials     2226     2229    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@battlmonstr battlmonstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@battlmonstr battlmonstr merged commit 26b2f90 into master Jul 29, 2024
15 checks passed
@battlmonstr battlmonstr deleted the ci/tidier13 branch July 29, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants