rpcdaemon: call ethbackend.canonical_body_for_storage if key empty in MaxTxNum #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lupin012
force-pushed
the
use_ethBackend_canonical_body_for_storage
branch
from
f537bdc
to
eef2839
Compare
canepat
changed the title
canepat
approved these changes
Oct 24, 2024
| @@ -33,10 +34,10 @@ namespace silkworm::db::txn { | |||
| using TxNum = TxnId; | |||
|
|
|||
| //! Return the maximum TxNum in specified \code block_number | |||
| Task<TxNum> max_tx_num(kv::api::Transaction& tx, BlockNum block_number); | |||
| Task<TxNum> max_tx_num(kv::api::Transaction& tx, BlockNum block_number, chain::CanonicalBodyForStorageProvider canonical_body_for_storage_provider); | |||
There was a problem hiding this comment.
canonical_body_for_storage_provider -> provider
|
|
||
| //! Return the minimum TxNum in specified \code block_number | ||
| Task<TxNum> min_tx_num(kv::api::Transaction& tx, BlockNum block_number); | ||
| Task<TxNum> min_tx_num(kv::api::Transaction& tx, BlockNum block_number, chain::CanonicalBodyForStorageProvider canonical_body_for_storage_provider); |
There was a problem hiding this comment.
canonical_body_for_storage_provider -> provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.