Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db, rpcdaemon: fix canonical_hash_provider for state reader #2450

Merged
merged 4 commits into from
Oct 25, 2024
Merged

db, rpcdaemon: fix canonical_hash_provider for state reader #2450

merged 4 commits into from
Oct 25, 2024

Conversation

canepat
Copy link
Member

@canepat canepat commented Oct 25, 2024 •
edited
Loading

Refactor state access abstractions after adding first_txn_num_in_block in kv::api::Transaction to avoid passing canonical hash provider in multiple call sites.

Extras

@canepat canepat mentioned this pull request Oct 25, 2024
Open
39 tasks
@canepat canepat added erigon3 Erigon3 feature maintenance Some maintenance work (fix, refactor, rename, test...) labels Oct 25, 2024
@canepat canepat marked this pull request as ready for review October 25, 2024 09:46
@canepat canepat merged commit 35a57d2 into master Oct 25, 2024
6 checks passed
@canepat canepat deleted the db_refactor_canonical_hash_providers branch October 25, 2024 10:16
@lupin012 lupin012 mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lupin012 lupin012 lupin012 approved these changes

@Sixtysixter Sixtysixter Awaiting requested review from Sixtysixter

Assignees
No one assigned
Labels
erigon3 Erigon3 feature maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@canepat @lupin012 @web-flow