Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from /usr/bin to /usr/bin/env #1

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

thinkverse
Copy link
Contributor

This PR switches bin/gdaisy to use /usr/bin/env php instead of /usr/bin/php, this lets the end-users environment pick which PHP version to use via its PATH, as oppose to gdaisy pointing to a specific version.

For me, this fixes the issue of gdaisy using the built-in PHP 7.1 instead of my homebrew versions, causing me to manually change the vendor file directly to get it to work instead of throwing parse errors.

Screen Shot 2021-06-09 at 10 04 31 PM

This is also an accepted practice, Laravel's artisan command uses this shebang, as well as Symfony in their Creating a Console Application example.

@erikaheidi erikaheidi merged commit b560dac into erikaheidi:main Jun 10, 2021
@erikaheidi
Copy link
Owner

Thank you!

@thinkverse thinkverse deleted the refactor-bin branch June 10, 2021 08:05
@thinkverse thinkverse restored the refactor-bin branch June 11, 2021 17:52
@thinkverse thinkverse deleted the refactor-bin branch June 11, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants