Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visionos platform support to podspec #530

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

gabrieldonadel
Copy link
Contributor

With the release of CocoaPods v1.13.0, visionOS support was introduced.

@erikdoe
Copy link
Owner

erikdoe commented Oct 3, 2023

Now I realise, of course, that this PR only adds visionOS to the podspec file. How would I add this to the Xcode project file? I'm on the latest Xcode but when I add a target I can't even choose visionOS (it's not under "other" either):

Screenshot 2023-10-03 at 23 40 27

@gabrieldonadel
Copy link
Contributor Author

gabrieldonadel commented Oct 3, 2023

Now I realise, of course, that this PR only adds visionOS to the podspec file. How would I add this to the Xcode project file? I'm on the latest Xcode but when I add a target I can't even choose visionOS (it's not under "other" either):

Screenshot 2023-10-03 at 23 40 27

AFAIK visionOS SDK is only available in Xcode Beta

image

@erikdoe
Copy link
Owner

erikdoe commented Oct 4, 2023

Okay, makes sense. So far the policy was that released versions of OCMock should not depend on beta features of Apple's tools. If I were to merge this PR, what would happen when someone who doesn't have the Xcode beta installed adds a dependency to that version of OCMock? Would they still be able to use the pod? Or would it fail because it contains a platform that their Xcode doesn't know about? (I don't know CocoaPods well.)

@gabrieldonadel
Copy link
Contributor Author

Okay, makes sense. So far the policy was that released versions of OCMock should not depend on beta features of Apple's tools. If I were to merge this PR, what would happen when someone who doesn't have the Xcode beta installed adds a dependency to that version of OCMock? Would they still be able to use the pod? Or would it fail because it contains a platform that their Xcode doesn't know about? (I don't know CocoaPods well.)

It should work, just like when you don't have a the watchos SDK installed in your Xcode for example

@erikdoe erikdoe merged commit 200756e into erikdoe:master Oct 4, 2023
@erikdoe
Copy link
Owner

erikdoe commented Oct 13, 2023

In case you wonder why this isn't released yet: #531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants