Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dockest): support function as commands for injecting the containerId into the command. #133

Conversation

n1ru4l
Copy link
Collaborator

@n1ru4l n1ru4l commented Feb 3, 2020

This makes it much easier to run commands inside your container, e.g. a database dump import.

…erId into the command.

This makes it much easier to run commands inside your container, e.g. a database dump import.
@erikengervall
Copy link
Owner

This makes it much easier to run commands inside your container, e.g. a database dump import.

Nice 👍

Could you update one command in one of the examples with the new format, simply for testing purposes? 🙂

@erikengervall
Copy link
Owner

erikengervall commented Feb 3, 2020

@n1ru4l Do you know how to make GitHub Actions run for this PR? 😕

@n1ru4l
Copy link
Collaborator Author

n1ru4l commented Feb 3, 2020

I think you must update the workflow to run on [push, pull_request] (https://git.luolix.topmunity/t5/GitHub-Actions/PR-from-fork-does-not-show-actions-even-though-actions-start-on/td-p/39895)

@erikengervall
Copy link
Owner

I think you must update the workflow to run on [push, pull_request] (https://git.luolix.topmunity/t5/GitHub-Actions/PR-from-fork-does-not-show-actions-even-though-actions-start-on/td-p/39895)

Thanks!

Saw that the workflows ran successfully on your fork, so I'll approve this.

I'll also add this to the docs along with the pipeline update 🙂

@erikengervall erikengervall merged commit feeff5f into erikengervall:master Feb 3, 2020
@n1ru4l n1ru4l deleted the feat-inject-container-id-into-commands branch February 3, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants