Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new helper 'resolveServiceAddress' #162

Merged
merged 2 commits into from
Mar 26, 2020

Conversation

n1ru4l
Copy link
Collaborator

@n1ru4l n1ru4l commented Mar 17, 2020

closes #160

@erikengervall
Copy link
Owner

erikengervall commented Mar 17, 2020

Would it make sense publishing the helpers as a separate module?

We wouldn't have to do this semi-hacky stuff

{
"name": "dockest/test-helper",
"private": true,
"main": "../dist/test-helper",
"typings": "../dist/test-helper/index.d.ts"
}

WDYT?

Perhaps it's not super straightforward since it's using utils from dockest.. 😕

Copy link
Owner

@erikengervall erikengervall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

However, I'd love for this to be incorporated into the documentation when you've got time

@n1ru4l
Copy link
Collaborator Author

n1ru4l commented Mar 18, 2020

Would it make sense publishing the helpers as a separate module?

I don't think so, it might seem semi-hacky, but it actually totally conforms with how Node.js resolves modules.


However, I'd love for this to be incorporated into the documentation when you've got time

@erikengervall Sure, can you point me in the right direction?

the readme of the website states that I should start editing in the docs folder. There is, however, only a versioned_docs folder. Should I start editing inside the versioned_docs/version-2.0.0 folder, or do I need to create a new one e.g. versioned_docs/version-2.1.0?


I also noticed that the following link is dead: http://localhost:3000/dockest/docs/2.0.0/introduction
goto http://localhost:3000/dockest/versions and click on 2.0.0 | Documentation

(same applies for the live page) https://erikengervall.github.io/dockest/docs/2.0.0/introduction

@erikengervall
Copy link
Owner

Would it make sense publishing the helpers as a separate module?

I don't think so, it might seem semi-hacky, but it actually totally conforms with how Node.js resolves modules.

Ok! 👍

However, I'd love for this to be incorporated into the documentation when you've got time

@erikengervall Sure, can you point me in the right direction?

the readme of the website states that I should start editing in the docs folder. There is, however, only a versioned_docs folder. Should I start editing inside the versioned_docs/version-2.0.0 folder, or do I need to create a new one e.g. versioned_docs/version-2.1.0?

I also noticed that the following link is dead: http://localhost:3000/dockest/docs/2.0.0/introduction
goto http://localhost:3000/dockest/versions and click on 2.0.0 | Documentation

(same applies for the live page) https://erikengervall.github.io/dockest/docs/2.0.0/introduction

I'll try to find some time this week to fix and add some instructions for how to add documentation.

To unblock this PR, we could create an issue to document these helpers.

@erikengervall erikengervall merged commit c7f3de3 into erikengervall:master Mar 26, 2020
@n1ru4l n1ru4l deleted the feat-test-helper branch March 26, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test helpers: getServiceAddress reconsiderations
2 participants