-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new helper 'resolveServiceAddress' #162
Conversation
Would it make sense publishing the helpers as a separate module? We wouldn't have to do this semi-hacky stuff dockest/packages/dockest/test-helper/package.json Lines 1 to 6 in 8330f6a
WDYT? Perhaps it's not super straightforward since it's using utils from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
However, I'd love for this to be incorporated into the documentation when you've got time
I don't think so, it might seem semi-hacky, but it actually totally conforms with how Node.js resolves modules.
@erikengervall Sure, can you point me in the right direction? the readme of the website states that I should start editing in the I also noticed that the following link is dead: http://localhost:3000/dockest/docs/2.0.0/introduction (same applies for the live page) https://erikengervall.github.io/dockest/docs/2.0.0/introduction |
Ok! 👍
I'll try to find some time this week to fix and add some instructions for how to add documentation. To unblock this PR, we could create an issue to document these helpers. |
closes #160