-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docker-compose file decoding #184
fix: docker-compose file decoding #184
Conversation
…te to latest docker-compose file format
@erikengervall Let me know what you think :) |
@erikengervall ping :) |
Sorry for the late reply - been a busy few weeks 🙂 I'll take a look tonight! 🙌 |
@erikengervall yes! I actually thought that I did update them already 😅 |
It seems like the port format got reverted to in 1.27.4: docker/compose@1.27.3...1.27.4 (https://docs.docker.com/compose/release-notes/#1274) I would stay we should steel keep the decoding, as it gives another layer of confidence. Please let me know what you think! |
@erikengervall Any ideas what's wrong with the unit tests? Some checks are not reported but required? I would love to see this merged quickly! Gonna pick up and finish #167 afterwards 🙂 |
I'll take a look when I get home later today :) |
Alright idk why GitHub Actions are acting up, the tests are seemingly passing and I've tried running them locally with the most recent changes. I'll merge this and create a new release 🙂 |
Closes #183