Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an action with an actual type to get the initialSate #115

Merged
merged 4 commits into from
Oct 8, 2016
Merged

Use an action with an actual type to get the initialSate #115

merged 4 commits into from
Oct 8, 2016

Conversation

yched
Copy link
Contributor

@yched yched commented Oct 6, 2016

Fixes #114

yesmeck
yesmeck requested changes Oct 6, 2016
View reviewed changes
Copy link
Collaborator

@yesmeck yesmeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the same change should apply to the immutableMultireducer please.

src/plainMultireducer.js
@@ -11,9 +11,10 @@ export default function plainMultireducer(reducers, reducerKey) {
}
}

const initAction = {type: '@@multireducer/INIT'};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a space after "{" and "}".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sure

@yched
Copy link
Contributor Author

yched commented Oct 7, 2016

Right, forgot immutableMultireducer. Done

@yesmeck yesmeck merged commit 97ce4cc into erikras:master Oct 8, 2016
@yesmeck
Copy link
Collaborator

yesmeck commented Oct 9, 2016

Published in v3.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesmeck yesmeck yesmeck requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yched @yesmeck