Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You may remove NoErrorsPlugin with React Hot Loader 1.3.0 #147

Closed
gaearon opened this issue Aug 28, 2015 · 4 comments
Closed

You may remove NoErrorsPlugin with React Hot Loader 1.3.0 #147

gaearon opened this issue Aug 28, 2015 · 4 comments

Comments

@gaearon
Copy link
Contributor

gaearon commented Aug 28, 2015

React Hot Loader 1.3.0 fixes a problem that caused NoErrorsPlugin to be necessary. In fact now errors thrown on module level shouldn't prevent future hot reloading of the same file after you fix the problem.

Please update to RHL 1.3.0, and remove NoErrorsPlugin from Webpack configuration.
Thanks!
@erikras
Copy link
Owner

erikras commented Aug 28, 2015

Will do asap (Monday). Weekend PRs accepted.

@mikekidder
Copy link
Contributor

PR #149 is ready; looks like someone created #148 (didn't see it til after I submitted), but doesn't remove the line in your webpack configuration.

They may update, so either one. :)

@LarryEitel
Copy link

You found NoErrorsPlugin and removed it. :)

@mikekidder
Copy link
Contributor

Sorry, @LarryEitel didnt mean to step on your PR. I had actually just recently forked this repo anyways to take a look. :)

@erikras erikras closed this as completed Aug 30, 2015
coopy pushed a commit to FormidableLabs/builder-victory-component that referenced this issue Jan 14, 2016
Remove NoErrorsPlugin
a238e22 
No longer needed with react-hot-loader upgrade:
erikras/react-redux-universal-hot-example#147
@wlcdesigns wlcdesigns mentioned this issue Nov 16, 2022
Open
@neolivz neolivz mentioned this issue Nov 16, 2022
Open
@wlcdesigns wlcdesigns mentioned this issue Nov 29, 2022
Open
@neolivz neolivz mentioned this issue Nov 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mikekidder @LarryEitel @gaearon @erikras