remove router transition hook when unmounting #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transition hook is being added every time the component is mounted so its gets called more and more times with every mount/unmount. Not a big deal in this component since it never unmounts, but a good example to follow for child components that do switch out.
erikras
added a commit
that referenced
this pull request
Jul 31, 2015
remove router transition hook when unmounting
|
Good one. Someone mentioned that the other day (you?), and I hadn't gotten around to it. Thanks! |
This was referenced Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transition hook is being added every time the component is mounted so its gets called more and more times with every mount/unmount. Not a big deal in this component since it never unmounts, but a good example to follow for child components that do switch out.