[Python] Add python commissioning flow #85
Conversation
erjiaqing
force-pushed
the
repl/python-commissioner
branch
10 times, most recently
from
0384e9e to
a656dc4
Compare
| if isinstance(parameter, commissioning.PaseOverBLEParameters): | ||
| devCtrl.EstablishPASESessionBLE(parameter.setup_pin, parameter.discriminator, parameter.temporary_nodeid) | ||
| elif isinstance(parameter, commissioning.PaseOverIPParameters): | ||
| devCtrl.EstablishPASESessionIP(parameter.address, parameter.setup_pin, parameter.temporary_nodeid) |
There was a problem hiding this comment.
We should not using directly addresses. We should take CommissionableNode for PaseOverIPParameters.
There was a problem hiding this comment.
Resolved, now establish_session will resolved the address.
| self.execute_device_cmd(req_device_id, "pip3 install {}".format(os.path.join( | ||
| CHIP_REPO, "out/debug/linux_x64_gcc/controller/python/chip_clusters-0.0-py3-none-any.whl"))) | ||
| self.execute_device_cmd(req_device_id, "pip3 install {}".format(os.path.join( | ||
| CHIP_REPO, "out/debug/linux_x64_gcc/controller/python/chip_core-0.0-cp37-abi3-linux_x86_64.whl"))) | ||
| self.execute_device_cmd(req_device_id, "pip3 install {}".format(os.path.join( | ||
| CHIP_REPO, "out/debug/linux_x64_gcc/controller/python/chip_repl-0.0-py3-none-any.whl"))) |
There was a problem hiding this comment.
Is there a way to reuse machinery we already have?
There was a problem hiding this comment.
We have a few patterns like this in the cirque test, will do a cleanup and add a help function in the CHIPVirtualHome class
| if name is None: | ||
| self._name = "caIndex(%x)/fabricId(0x%016X)/nodeId(0x%016X)" % (fabricAdmin.caIndex, fabricId, nodeId) | ||
| else: | ||
| self._name = name |
There was a problem hiding this comment.
This name allocation logic was OK
| c_void_p), c_uint64, c_uint64, c_uint16, c_char_p, c_bool, c_bool, POINTER(c_uint32), c_uint32] | ||
| self._dmLib.pychip_OpCreds_AllocateController.restype = PyChipError | ||
|
|
||
| self._dmLib.pychip_OpCreds_AllocateControllerForCustomCommissioningFlow.argtypes = [ |
There was a problem hiding this comment.
Why is this a special case? We should be able to make this possible (externally initialized controller credentials) even for non-custom-flow commissioning.
| ''' A bare device controller without commissioner support. | ||
| ''' | ||
|
|
||
| def __init__(self, ephemeralKey: bytes, noc: bytes, icac: bytes, rcac: bytes, adminVendorId: int, name: str = None): |
There was a problem hiding this comment.
Please wrap the P256Keypair here so it can be passed from a Python bridge, rather than raw bytes. For working with an external CA, we won't have the raw bytes, but sometimes we will. It's easier to abstract away by passing the keypair in.
Also, as mentioned in other comment, we need to include the IPK or add a method to replace the IPK once we have it from the credentials provider.
src/controller/python/chip/commissioning/DummyOperationalCredentialsIssuer.h
Outdated
Show resolved
Hide resolved
| namespace chip { | ||
| namespace Python { | ||
|
|
||
| class DLL_EXPORT DummyOperationalCredentialsIssuer : public Controller::OperationalCredentialsDelegate |
There was a problem hiding this comment.
Rename Dummy to Placeholder everywhere
| // Constructor to create an instance of this object that vends out operational credentials for a given fabric. | ||
| // | ||
| // An index should be provided to numerically identify this instance relative to others in a multi-fabric deployment. This is | ||
| // needed given the interactions of this object with persistent storage. Consequently, the index is used to scope the entries | ||
| // read/written to/from storage. | ||
| // | ||
| // It is recommended that this index track the fabric index within which this issuer is operating. |
erjiaqing
force-pushed
the
repl/python-commissioner
branch
2 times, most recently
from
c42acb7 to
b4da241
Compare
erjiaqing
force-pushed
the
repl/python-commissioner
branch
from
b4da241 to
3bb6133
Compare
github-actions
bot
added
app
examples
github
gn
integrations
platform
tests
tools
workflows
setup payload
linux
tizen
labels
This PR introduces manually commissioning flow in Python, with a example of commissioning without autocommissioner. For testing potential commissioning flow changes in the future since it is more flexible. It can also be used to test a few corner cases during commissioning, including bad certificate chain etc.
This PR also splits the Controller in Python into two parts, ControllerBase (like Controller in C++, actually backed with a Commissioner with dummy CertificateIssuer), and Controller (the Commissioner), the ControllerBase can be initialized with a certificate signed by someone else.
This PR only includes changes to Python scripts and necessary C++ interfaces.
The changes to CHIP Tool will be done later in separate PR.