Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regarding document (Not urgent, but might help) #8

Closed
kevinirlen opened this issue May 29, 2024 · 2 comments · Fixed by #9
Closed

Regarding document (Not urgent, but might help) #8

kevinirlen opened this issue May 29, 2024 · 2 comments · Fixed by #9

Comments

@kevinirlen
Copy link
Contributor

It might be worth noting inside the documentation, that the User entity has to implement the Erkens\Security\TwoFactorTextBundle\Model\TwoFactorTextInterface interface maybe?

Without this, things doesn't work as expected.

Any thoughts @erkens ?
@kevinirlen
Copy link
Contributor Author

I created a pull request for this. If you can review :)

@erkens erkens linked a pull request May 29, 2024 that will close this issue
#8 Adding information about User-entity changes in README.md #9
Merged
@erkens erkens closed this as completed in #9 May 29, 2024
erkens pushed a commit that referenced this issue May 29, 2024
@kevinirlen
#8 Adding information about User-entity changes in README.md (#9)
30feb14 
* Update README.md

The User entity must implement the Erkens\Security\TwoFactorTextBundle\Model\TwoFactorTextInterface
@erkens
Copy link
Owner

erkens commented May 29, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#8 Adding information about User-entity changes in README.md kevinirlen/2fa-text
2 participants
@erkens @kevinirlen