Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: wrong selected value in different fontSize/itemHeight #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aliunco
Copy link

@aliunco aliunco commented Jul 2, 2023

If you are using certain functionalities to enable responsive design, such as scaled font sizes, height adjustments, and boundaries, you may encounter bugs where incorrect values are passed through the onChange function.

In this branch, I have optimized the calculation of this value and eliminated the bug. 🙃

Thanks for reviewing this PR (in advance)

- optimizing the caculation for handleMomentumScrollEnd and make it work better (without bug) while using differrent fontSize or itemHeights
@aliunco aliunco changed the title bugfix: bugfix: wrong selected value in different fontSize/itemHeight Jul 2, 2023
@tranminhkhang7
Copy link

Pls refer to this issue. That solves my problem:

#49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants