socket-nif: Fix string argument passing for setsockopt #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing a string into setsockopt we have to use the pointer to the string, not a pointer to a pointer. Affects the socket bindtodevice and tcp congestion option.
|
Note: the same fix should IMHO also be applied to all 22.x releases. |
RoadRunnr
force-pushed
the
fix/socket-bindtodevice
branch
from
00e16c3
to
97d4b6c
Compare
IngelaAndin
added
team:PS
This was referenced May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing a string into setsockopt we have to use the pointer to
the string, not a pointer to a pointer.
Affects the socket bindtodevice and tcp congestion option.