ssl: Make sure handshake messages are handled correctly during versio… #6037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IngelaAndin
added
team:PS
KennethL
suggested changes
May 31, 2022
…n negotiation Handshake messages MAY be coalesced into a single TLSPlaintext record or fragmented across several records. There are also stricter conditions that must be met for TLS-1.3 "see RFC 8446 section 5.1. Record Layer" This means that when supporting both TLS-1.2 and TLS-1.3 as a client we need to make sure that only the server hello message is handled initially so that possible coalesced TLS-1.2 handshake messages will be handled by TLS-1.2 code when the negotiated version has been established. Closes erlang#5961
IngelaAndin
force-pushed
the
ingela/ssl/tls-record-handling/GH-5961/OTP-18087
branch
from
f696264 to
3192d81
Compare
CT Test Results 2 files 64 suites 44m 28s ⏱️ Results for commit 85c88e8. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
@KennethL I made some clarifying changes in the code in my new version of the PR. |
u3s
approved these changes
Jun 2, 2022
|
I merged my local branch containing this change as I did want to solve the merge conflict via github. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n negotiation
Handshake messages MAY be coalesced into a single TLSPlaintext record
or fragmented across several records. There are also stricter conditions
that must be met for TLS-1.3 "see RFC 8446 section 5.1. Record Layer"
This means that when supporting both TLS-1.2 and TLS-1.3 as a client we need to
make sure that only the server hello message is handled initially so that
possible coalesced TLS-1.2 handshake messages will be handled by TLS-1.2 code
when the negotiated version has been established.
Closes #5961