Fix windows pdb #9229
Open
Fix windows pdb #9229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual Studio 17 seems to compile the original code into something that make coverage into MAX_SMALL instead of coverage_data. Extracting the data into a variable seems to fix the error, don't know why but hopefully it will be fixed in the compiler someday. Or maybe the original code is somesort of undefined behaviour I'm unable to see. The original code compiles as it should in Visual Studio 14.
When debugging on windows, the name of the pdb file is not the name of the file being debugger, but the name of the file as it was compiled. We rename beam.jit.dll to beam.smp.dll during the build so the pdb needed is called jit.pdb and not smp.pdb. We also make sure to release all pdb files so that they are part of the installer.
garazdawi
force-pushed
the
lukas/erts/fix-windows-pdb
branch
from
068fb0d to
59dd2b3
Compare
CT Test Results 3 files 141 suites 49m 2s ⏱️ Results for commit 0480095. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
force-pushed
the
lukas/erts/fix-windows-pdb
branch
from
59dd2b3 to
0505bd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues on Windows, mainly it makes sure that the correct pdb files are released so that they are part of the installer and can be used to debug crashes in erts.