jit: Allow forcing Windows ABI to help find Windows bugs under Linux #9236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhogberg
added
team:VM
CT Test Results 3 files 141 suites 50m 7s ⏱️ Results for commit 95df381. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
jhogberg
removed
the
testing
jhogberg
force-pushed
the
john/jit/improve-runtime-call-debugging
branch
4 times, most recently
from
50b0379 to
519ff61
Compare
jhogberg
force-pushed
the
john/jit/improve-runtime-call-debugging
branch
from
519ff61 to
95df381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I lack a decent Windows environment and felt too lazy to set one up while looking into #9222, I figured I'd dust off an old experiment of mine that used alternative ABIs in the JIT. The idea was that if the crash was caused by a Windows-specific JIT bug, we should be able to reproduce it on Linux by using the Windows ABI.
It turns out that I can't reproduce the bug with this, but since we've had other bugs of this sort we may as well add it now that I've put in the work. While we're at it, we'll also add improved function-signature checking to the ARM JIT.