Fix load order for custom project builders and parse transforms #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to building dependencies with potential artifacts such as parse transforms or macros, project builder plugins should be included in the path, but _after_ deps are loaded. Doing otherwise means that if any of the dependencies is required at compile time, those of a plugin might get used first.
|
Tristan pointed out that this should only impact paths when using custom builders so this likely does not fix #1962 yet. I'll need to investigate further |
ferd
changed the title
Compile time with parse transforms needs to have the deps first in scope before the plugins
ferd
changed the title
The app data, when set by `rebar3_app_discover` basically does not include the modules if it was derived from the .app.src file, even if at a later point the modules were compiled. Since there is currently no clear way to add that information reliably across all compiler versions in all types of compilers, we simply clear the cache and re-derive the information when required. This might have a small performance cost, but is required for correctness whenever an application's first build is run. Specifically, this bug was detected when a plugin included lager's parse transform, and the application itself also required it, but two distinct versions were needed. This patch finalizes fixing this issue.
|
Alright this seems to work in all scenarios. Turns out the app details cache was not always blown after compiling, and since we don't know where exactly in the workflow rebar_paths is called, I just decided to always ignore the app detail cache for the lookups. This seems to fix everything up. |
tsloughter
reviewed
Dec 1, 2018
tsloughter
reviewed
Dec 1, 2018
tsloughter
approved these changes
Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to building dependencies with potential artifacts such as parse
transforms or macros, project builder plugins should be included in the
path, but after deps are loaded.
Doing otherwise means that if any of the dependencies is required at
compile time, those of a plugin might get used first.
Fixes #1962 // awaiting confirmation by @hommeabeil