Do not discard parameters --system_libs and --include-erts when duplicate values exist #2695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging #2503 it was not taken for account that
include_erts
and the other variables can be present multiple time in theRelxConfig
. This can occurs when a variable is define in a profile. Following is anrebar.config
file example and the result before this fix.The solution propose is to replace all the occurrence before sending them to rlx_config:to_state. The reason the problem exist is because the rlx_config:to_state use
list:foldl
so the last occurence take preceence.