Always dereference symbolic links when copying files in ct #2740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the patch I did for dereferencing symbolic links in common tests does not always work (I should have tried all the combinations).
The
copy_bare_suites
function only runs when the ct suite is placed in the root folder, but it doesn't run when it is placed in theapps/app_name/test/
folder. The first commit adds a test showing that this is the case.In the second commit, I added
copy_bare_suites
to all the cases ofmaybe_inject_test_dir
. I also forced dereferencing when copying the folders inrebar_prv_compile
. I couldn't think in a case where this is not wanted and sincerebar_prv_compile
does run aftercopy_bare_suites
, it always override the changes done byrebar3_prv_common_test
.