This repository has been archived by the owner on Sep 22, 2024. It is now read-only.
Filter not started children when generating supervisor nodes #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baransu
approved these changes
Apr 12, 2017
michalslaski
approved these changes
Apr 13, 2017
There was a problem hiding this comment.
@arkgil do you think it would make sense to merge epl_st with the erlangpl repo under apps/ ?
|
I think this is good idea to keep core functionality we have right now under one repo. After plugin system is complete we can create new parts based on that. |
|
Yes, that's a good idea. I thought I'd wait until I change plugin loader so that plugins must be Erlang applications, but I can just move |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This little change fixes #7 (and erlanglab/erlangpl#43). Now we filter list of supervisor's children to exclude the ones which are not started.
After merge, we need to release and tag version 0.1.1 of
epl_st, updateerlangplto include new version and tag 0.6.1.