This repository has been archived by the owner on Sep 22, 2024. It is now read-only.
Merge erlangpl-ui into erlangpl #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement basic vizceral-react graph and websockets
baransu
changed the title
|
I've moved |
|
I think that's fine. I'd also keep ui in subdirectory, it'll make things a little bit cleaner. Thanks for taking care of that! |
|
@arkgil @michalslaski what should we do with old UI repo? |
|
We can make it private or delete it. We may also deprecate it for a little while, and delete it later. |
baransu
changed the title
|
Waiting for @michalslaski's review, and after that I think we can merge! 🎉 |
|
@baransu I can review early next week, but don't wait for it. Feel free to merge now, so that you can progress with new developments. |
|
Awesome, going to merge later today 🎉🎊 |
arkgil
approved these changes
Apr 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've merged
erlangpl-uiintouifolder withinerlangplrepo. I don't know if subdirectory is good solution. I would rather merge it into root directory because we don't have any naming conflicts and it would simplify building, developing and probably other things. What do you think?What should we do with old repo? Delete or keep it with deprecation note?