Skip to content
This repository has been archived by the owner on Sep 22, 2024. It is now read-only.

Add JS code formatting #47

Merged
merged 2 commits into from
May 1, 2017
Merged

Add JS code formatting #47

merged 2 commits into from
May 1, 2017

Conversation

baransu
Copy link
Contributor

@baransu baransu commented Apr 13, 2017

Prettier is an awesome tool for JS code formatting. We were requiring it in our README section in old UI repo.

Recently version 1.0 of prettier come out so I thought it's a good moment to add it as pre-commit hook.

I want to add similar thing for Elm later: https://github.com/avh4/elm-format

@arkgil
Copy link
Contributor

arkgil commented Apr 13, 2017

Consistent code formatting is a sign of good quality 👍 Do I understand correctly that it doesn't configure actual git pre-commit hook? From what I've read some time ago, it's only possible to set them in local repositories.

@baransu
Copy link
Contributor Author

baransu commented Apr 13, 2017

Prettier only runs only on .js files formatting them. We're using another dependency for git pre-commit hook. In other project I had flow to typecheck JS before every commit.

@baransu baransu added this to the 0.7 milestone Apr 18, 2017
@baransu
Copy link
Contributor Author

baransu commented Apr 20, 2017

I've updated prettier to newest version. I've also added elm-format for formatting Elm code.

@arkgil arkgil merged commit 8ec15d2 into master May 1, 2017
@arkgil arkgil deleted the add-prettier branch May 1, 2017 22:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants