We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
access.expires
3.1.0-beta.2
26.0.3
1.15.4
There's a discrepancy between the documentation and the implementation for the expires value of an access token.
expires
I don't have a strong feeling about which one should be correct
The documentation for oidc_token.access() says that expires is the timestamp when the token expires.
However, the implementation seems to use a number of seconds the token is valid.
I don't have a strong opinion about which one is correct, but it's probably easier to update the documentation than the code.
The text was updated successfully, but these errors were encountered:
@paulswartz The implementation is just passing through the value, which i believe is expected when reading the OpenID specification.
I therefore prefer adjusting the docs.
Sorry, something went wrong.
doc: correct documentation for oidcc_token:access()
oidcc_token:access()
376eef5
Fixes: erlef#292
cc2f637
doc: correct documentation for oidcc_token:access() (#293)
9a332f8
Fixes: #292
paulswartz
Successfully merging a pull request may close this issue.
oidcc version
3.1.0-beta.2
Erlang version
26.0.3
Elixir version
1.15.4
Summary
There's a discrepancy between the documentation and the implementation for the
expires
value of an access token.I don't have a strong feeling about which one should be correct
Current behavior
The documentation for oidc_token.access() says that
expires
is the timestamp when the token expires.However, the implementation seems to use a number of seconds the token is valid.
How to reproduce
expires
is generally under 1000, which is not a timestamp.Expected behavior
I don't have a strong opinion about which one is correct, but it's probably easier to update the documentation than the code.
The text was updated successfully, but these errors were encountered: