Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: value of access.expires? #292

Closed
paulswartz opened this issue Nov 21, 2023 · 1 comment · Fixed by #293
Closed

question: value of access.expires? #292

paulswartz opened this issue Nov 21, 2023 · 1 comment · Fixed by #293
Assignees
Labels
Milestone

Comments

@paulswartz
Copy link
Collaborator

oidcc version

3.1.0-beta.2

Erlang version

26.0.3

Elixir version

1.15.4

Summary

There's a discrepancy between the documentation and the implementation for the expires value of an access token.

I don't have a strong feeling about which one should be correct

Current behavior

The documentation for oidc_token.access() says that expires is the timestamp when the token expires.

However, the implementation seems to use a number of seconds the token is valid.

How to reproduce

  • Get an access token
  • See that the value for expires is generally under 1000, which is not a timestamp.

Expected behavior

I don't have a strong opinion about which one is correct, but it's probably easier to update the documentation than the code.

@paulswartz paulswartz added the bug label Nov 21, 2023
@maennchen
Copy link
Member

@paulswartz The implementation is just passing through the value, which i believe is expected when reading the OpenID specification.

I therefore prefer adjusting the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants