Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate / Cast Token Responses #306

Closed
maennchen opened this issue Dec 13, 2023 · 0 comments · Fixed by #308
Closed

Validate / Cast Token Responses #306

maennchen opened this issue Dec 13, 2023 · 0 comments · Fixed by #308
Assignees
@maennchen
Labels
bug
Milestone
v3.2.0

Comments

@maennchen
Copy link
Member

oidcc version

3.1.2-beta.1

Erlang version

26.2

Elixir version

1.15.7

Summary

oidcc should validate / cast token responses as it does for the provider metadata.

Current behavior

Given an Azure AD token response, the #oidcc_token_access.expires_in is a string and not a number as expected.

How to reproduce

Request token from Azure AD and check response.

Expected behavior

The fields of the token response should be cast and validated.
@maennchen maennchen self-assigned this Dec 14, 2023
maennchen added a commit that referenced this issue Dec 14, 2023
@maennchen
Properly Validate & Cast Token Responses (#306)
6d4f9fd
@maennchen maennchen mentioned this issue Dec 14, 2023
Merged
maennchen added a commit that referenced this issue Dec 14, 2023
@maennchen
Properly Validate & Cast Token Responses (#306)
df4780b
maennchen added a commit that referenced this issue Dec 14, 2023
@maennchen
Properly Validate & Cast Token Responses (#306)
2891795
maennchen added a commit that referenced this issue Dec 14, 2023
@maennchen
Properly Validate & Cast Token Responses (#306) (#308)
a91a6da
@maennchen maennchen added this to the v3.2.0 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maennchen maennchen

Labels
bug
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging a pull request may close this issue.

Properly Validate & Cast Token Responses (#306) erlef/oidcc
1 participant
@maennchen