Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: application:get_env/2 returns {ok, Value} #288

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

paulswartz
Copy link
Collaborator

Ran into this while trying to use max_clock_skew to investigate something else. This didn't appear to be covered by tests, but happy to add them if you can point me in the right direction.

@maennchen
Copy link
Member

@paulswartz Good catch.

A test for this would be awesome. We could probably duplicate the retrieve_rs256_with_rotation_test and remove the rotation parts. Instead we can set the nbf / exp fields to slightly expired valuues and use the clock skew to still make it pass.

retrieve_rs256_with_rotation_test() ->

@paulswartz
Copy link
Collaborator Author

@maennchen thank you for the pointer! I ended up using a simpler test example (less to remove!) but let me know if you don't think that works.

Copy link
Member

@maennchen maennchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thanks so much for the tests as well :)

@maennchen maennchen added the bug label Nov 21, 2023
@maennchen maennchen merged commit 4a99b4d into erlef:main Nov 21, 2023
24 checks passed
@maennchen maennchen added this to the v3.1.0 milestone Nov 21, 2023
@maennchen maennchen self-assigned this Nov 21, 2023
@paulswartz paulswartz deleted the get_env branch November 21, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants