Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: preferred_auth_methods argument for request_token #291

Merged
merged 1 commit into from
Nov 21, 2023
Merged

feat: preferred_auth_methods argument for request_token #291

merged 1 commit into from
Nov 21, 2023

Conversation

paulswartz
Copy link
Collaborator

Fixes #289

maennchen
maennchen requested changes Nov 21, 2023
View reviewed changes
Copy link
Member

@maennchen maennchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great besides the small merge conflict issue.

test/oidcc_token_test.erl Outdated Show resolved Hide resolved
@maennchen maennchen added this to the v3.1.0 milestone Nov 21, 2023
@maennchen maennchen self-assigned this Nov 21, 2023
@maennchen maennchen enabled auto-merge (squash) November 21, 2023 16:03
@maennchen maennchen merged commit 77e4c0d into erlef:main Nov 21, 2023
22 checks passed
@paulswartz paulswartz deleted the preferred_auth_methods branch November 21, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maennchen maennchen maennchen approved these changes

Assignees

@maennchen maennchen

Labels
enhancement
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

ability to override preferred token auth methods
2 participants
@paulswartz @maennchen