fix: support unsigned ID tokens even when JOSE disables them #295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, JOSE disables verification of
none
alg JWTs, for (reasonable) security preferences. However,oidcc-client-test-idtoken-sig-none
says this is an optionally supported use case. This updates the implementation ofverify_signature
to return an error with the JWT/JWS values even when JOSE is configured not to allownone
signatures.