-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introspection improvements #300
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulswartz
commented
Dec 9, 2023
477a029
to
ae70156
Compare
Pull Request Test Coverage Report for Build 97
💛 - Coveralls |
ae70156
to
6daab69
Compare
maennchen
reviewed
Dec 9, 2023
maennchen
reviewed
Dec 9, 2023
maennchen
requested changes
Dec 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good besides the two little changes.
If the OP supports other kinds of auth (but not the basic auth header), this allows the introspection endpoint to work.
From https://datatracker.ietf.org/doc/html/rfc7662#section-2.2: > Specific implementations MAY extend this structure with their own > service-specific response names as top-level members of this JSON > object.
6daab69
to
4e3d1c2
Compare
maennchen
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client_secret_basic
(by extracting the code used inoidcc_token
)extra
to include values outside the spec