Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: document_overrides quirk to patch invalid OIDD files #307

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

paulswartz
Copy link
Collaborator

I don't love this as a bulk override, but it seems easier than needing to add a specific quirk for each attribute that it's possible for an OP to get wrong?

Copy link
Member

@maennchen maennchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s quite a good idea. It works for the grant types and also for the issuer mismatch. Not for the https exception though.

This will probably keep us from having to add a lot of quirks in the long run.

If we go down this route, we should deprecate the issuer mismatch and revert #304.

src/oidcc_provider_configuration.erl Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 103

  • 7 of 7 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 94.051%

Files with Coverage Reduction New Missed Lines %
src/oidcc_authorization.erl 1 89.86%
Totals Coverage Status
Change from base Build 135: -0.2%
Covered Lines: 743
Relevant Lines: 790

💛 - Coveralls

@maennchen maennchen self-assigned this Dec 14, 2023
@maennchen maennchen added this to the v3.2.0 milestone Dec 14, 2023
@maennchen maennchen merged commit 4757fe7 into erlef:main Dec 14, 2023
25 checks passed
@paulswartz paulswartz deleted the document-override branch January 5, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants