feat: Demonstrating Proof of Posession (DPoP) #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll need this for DPoP bound tokens, which use the `DPoP` type.
|
Awesome @paulswartz! Thanks for your work. It looks good on a first glance, but I‘ll need a day or two to properly review this change. |
maennchen
requested changes
Dec 21, 2023
|
@paulswartz I've compared the implementation with the RFC and as far as I can judge without actually executing the code, it looks great. After my few nitpicks above, I think we're ready to merge this. |
Co-authored-by: Jonatan Männchen <jonatan@maennchen.ch>
maennchen
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrating Proof of Possession (DPoP)