fix: small fixes for DPoP #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://gitlab.com/openid/conformance-suite/-/merge_requests/1354 has conformance tests which incorporate validation of the DPoP nonces, which uncovered a couple issues: - we were providing the nonce in the claims as a list of numbers (charlist) instead of a binary - `Oidcc.Token.Access.authorization_headers` didn't expose `opts` to provide the `dpop_nonce` value
paulswartz
force-pushed
the
dpop-fixes
branch
from
68634ff
to
66ea8e4
Compare
maennchen
reviewed
Jan 11, 2024
maennchen
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gitlab.com/openid/conformance-suite/-/merge_requests/1354 has conformance tests which incorporate validation of the DPoP nonces, which uncovered a couple issues:
Oidcc.Token.Access.authorization_headersdidn't exposeoptsto provide thedpop_noncevalue