Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement backoff algorithm for configuration worker #337

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Implement backoff algorithm for configuration worker #337

merged 1 commit into from
Feb 21, 2024

Conversation

maennchen
Copy link
Member

Closes #324

@maennchen maennchen added this to the v3.2.0 milestone Feb 20, 2024
@maennchen maennchen requested a review from paulswartz February 20, 2024 18:17
@maennchen maennchen self-assigned this Feb 20, 2024
@maennchen maennchen mentioned this pull request Feb 20, 2024
Closed
@coveralls
Copy link

coveralls commented Feb 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 162

Details

  • -1 of 28 (96.43%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 92.422%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/oidcc_provider_configuration_worker.erl 9 10 90.0%
Totals Coverage Status
Change from base Build 156: 0.2%
Covered Lines: 1061
Relevant Lines: 1148
💛 - Coveralls

paulswartz
paulswartz previously approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@paulswartz paulswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one non-blocking question, otherwise looks good to me!

src/oidcc_backoff.erl Show resolved Hide resolved
@maennchen maennchen merged commit ab661fd into main Feb 21, 2024
25 checks passed
@maennchen maennchen deleted the backoff branch February 21, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulswartz paulswartz paulswartz left review comments

Assignees

@maennchen maennchen

Labels
enhancement
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

oidcc_provider_configuration_worker backoff
3 participants
@maennchen @coveralls @paulswartz