Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always refresh keys on empty JWK #339

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

maennchen
Copy link
Member

Given an empty key set, the logic to prevent refreshes for keys without kid triggers and are never reloaded. This changes the logic so that an empty set always refreshes.

@maennchen maennchen added the bug label Mar 25, 2024
@maennchen maennchen added this to the v3.2.0 milestone Mar 25, 2024
@maennchen maennchen self-assigned this Mar 25, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 163

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 92.341%

Files with Coverage Reduction New Missed Lines %
src/oidcc_provider_configuration_worker.erl 1 96.34%
Totals Coverage Status
Change from base Build 161: -0.08%
Covered Lines: 1061
Relevant Lines: 1149

💛 - Coveralls

@maennchen maennchen merged commit d33ec80 into main Mar 25, 2024
25 checks passed
@maennchen maennchen deleted the always_reload_for_empty_jwk branch March 25, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants