Fix DPoP with JWK Set #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maennchen
force-pushed
the
dpop_jwk_set
branch
2 times, most recently
from
0508706
to
ee908cf
Compare
Pull Request Test Coverage Report for Build 172Details
💛 - Coveralls |
paulswartz
reviewed
Apr 30, 2024
There was a problem hiding this comment.
The code looks fine, but I get a lot of conformance suite failures when running against this branch. From a quick look, the DPoP header isn't being sent.
I'll try to find some time in the new day or two to dig into it more and figure out where the signature is being lost.
|
@paulswartz I assume this is because (I used this key to test conformance: https://github.com/erlef/oidcc_conformance/blob/f3c773576607ef5090328d7f2608a14496b480c5/artifacts/client.priv.jwkset) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.