Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate return type in create_redirect_url spec #358

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Nezteb
Copy link
Contributor

@Nezteb Nezteb commented Jun 26, 2024

While using oidcc, I noticed that one of the return types is duplicated. I wouldn't really define it as a bug, so I labelled it as an "improvement". 😄

@maennchen maennchen self-assigned this Jun 26, 2024
@maennchen
Copy link
Member

Thanks @Nezteb ❤️

@maennchen maennchen enabled auto-merge (squash) June 26, 2024 19:58
@maennchen maennchen merged commit cbd19a8 into erlef:main Jun 26, 2024
28 checks passed
@coveralls
Copy link

coveralls commented Jun 26, 2024

Pull Request Test Coverage Report for Build 191

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.6%) to 91.5%

Files with Coverage Reduction New Missed Lines %
src/oidcc_jwt_util.erl 2 79.33%
src/oidcc_token.erl 5 88.66%
Totals Coverage Status
Change from base Build 178: -0.6%
Covered Lines: 1055
Relevant Lines: 1153

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants