Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from set-output (while updating all deps) #148

Merged
merged 4 commits into from
Oct 19, 2022
Merged

Move away from set-output (while updating all deps) #148

merged 4 commits into from
Oct 19, 2022

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented Oct 16, 2022

What's getting done?

We're getting rid of warnings such as:

  • save-state will be deprecated
  • set-output will be deprecated
  • Node.js 12 is being deprecated
  • ...

while relying on tests to make sure the action still works as it should.

(also closes #146)

Versions updated

What Old New
actions/checkout v2 v3
actions/setup-node v2 v3
ubuntu 18.04 20.04 (removed where unusable)
actions/core 1.9.1 1.10.0
semver 7.3.6 7.3.8
vercel/ncc 0.33.4 0.34.0
eslint 8.14.0 8.25.0
eslint-plugin-jsx-a11y 6.5.1 6.6.1
eslint-plugin-react 7.29.0 7.31.10
husky 7.0.4 8.0.1
markdownlint 0.25.1 0.26.2
prettier 2.6.2 2.7.1
yaml-lint 1.3.0 1.7.0
yarn 1.22.18 1.22.19

@paulo-ferraz-oliveira paulo-ferraz-oliveira changed the title Update all our deps Move away from set-output (while updating all deps) Oct 16, 2022
@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as draft October 17, 2022 01:05
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Moving to draft while tests are failing...

@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as ready for review October 17, 2022 01:12
Get rid of warnings such as:
* `save-state` will be deprecated
* `set-output` will be deprecated
* nodejs 12 is being deprecated
...

Rely on tests to make sure the actions still works
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Rebased to include the issue I said #144 would solve.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Push a new commit to get rid of problem matcher -related warnings.

We're not testing rebar3 here, in any case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move away from set-output
2 participants