Skip to content

Commit

Permalink
pythongh-117347: Fix test_clinic side effects (python#117363)
Browse files Browse the repository at this point in the history
Save/restore converters in ClinicWholeFileTest and
ClinicExternalTest.
  • Loading branch information
vstinner authored Mar 29, 2024
1 parent 7e2fef8 commit 35b6c4a
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions Lib/test/test_clinic.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,20 @@ def _expect_failure(tc, parser, code, errmsg, *, filename=None, lineno=None,
return cm.exception


def restore_dict(converters, old_converters):
converters.clear()
converters.update(old_converters)


def save_restore_converters(testcase):
testcase.addCleanup(restore_dict, clinic.converters,
clinic.converters.copy())
testcase.addCleanup(restore_dict, clinic.legacy_converters,
clinic.legacy_converters.copy())
testcase.addCleanup(restore_dict, clinic.return_converters,
clinic.return_converters.copy())


class ClinicWholeFileTest(TestCase):
maxDiff = None

Expand All @@ -60,6 +74,7 @@ def expect_failure(self, raw, errmsg, *, filename=None, lineno=None):
filename=filename, lineno=lineno)

def setUp(self):
save_restore_converters(self)
self.clinic = _make_clinic(filename="test.c")

def test_eol(self):
Expand Down Expand Up @@ -2431,6 +2446,9 @@ def test_state_func_docstring_only_one_param_template(self):
class ClinicExternalTest(TestCase):
maxDiff = None

def setUp(self):
save_restore_converters(self)

def run_clinic(self, *args):
with (
support.captured_stdout() as out,
Expand Down

0 comments on commit 35b6c4a

Please sign in to comment.