Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erlang.mk compatibility #13

Closed
wants to merge 1 commit into from
Closed

erlang.mk compatibility #13

wants to merge 1 commit into from

Conversation

qrilka
Copy link

@qrilka qrilka commented Oct 10, 2014

Empty "modules" in iso8601.app.src + removed ebin.
It was not clear why do you have ebin in the repository

It is required to make app compatible with erlang.mk
@oubiwann
Copy link
Member

oubiwann commented May 12, 2016

@qrilka I don't use erlang.mk ... but your change implies that erlang.mk doesn't work when modules are defined in app.src? (I ask because this seems odd to me ...)

@oubiwann
Copy link
Member

@lukebakken Per the note in #15 (which was closed as a duplicate), some thoughts:

  • +1 for removing the app.src file in ./ebin (that's been done now)
  • -1 for making modules empty -- this will break other tools

It's been a couple of years since erlang.mk came out, now ... does this still need to be done?

If so, we need to find a way to support erlang.mk that doesn't impact other tools.

@qrilka
Copy link
Author

qrilka commented May 12, 2016

I don't have a context of this PR in my mind anymore and there were some changes in erlang.mk and I haven't used it (erlang.mk) for a couple of years already.
I don't use Erlang lately so feel free to go the way you want about this ticket.

@oubiwann
Copy link
Member

@qrilka Thanks for writing back! Sorry it took us so long to respond :-(

I've since created a help-wanted ticket for this, so I will close this PR allowing another contributor to work on just what's necessary.

Thanks again!

@oubiwann oubiwann closed this May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants