Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relx_app_info:optional_applications/1 looks at wrong attribute #934

Closed
uwiger opened this issue Feb 21, 2024 · 1 comment · Fixed by #943
Closed

relx_app_info:optional_applications/1 looks at wrong attribute #934

uwiger opened this issue Feb 21, 2024 · 1 comment · Fixed by #943

Comments

@uwiger
Copy link
Contributor

uwiger commented Feb 21, 2024

In relx_app_info.erl

-spec optional_applications(t()) -> [atom()].
optional_applications(#{included_applications := Deps}) ->
    Deps.

This seems like a copy-paste error
@tsloughter
Copy link
Member

That it is :)

@richcarl richcarl mentioned this issue Dec 12, 2024
Closed
richcarl added a commit to richcarl/relx that referenced this issue Dec 12, 2024
@richcarl
Fix copy/paste error
5a7d2f8 
Getter `optional_applications` returned wrong field.
Fixes erlware#934
@richcarl richcarl mentioned this issue Dec 12, 2024
Merged
@ferd ferd closed this as completed in #943 Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix copy/paste error richcarl/relx
2 participants
@tsloughter @uwiger