Make scripts in rlx_prv_assembler DTL templates

[nuex]

This moves scripts out of the rlx_prv_assembler and into their own DTL template files in priv/templates.

This will work with the latest rebar.

[jwilberding]

@nuex could you clean this up so it passes the CI build?

[nuex]

I think it failed because Travis didn't have an updated rebar. Latest rebar should build it fine. Any way you can restart the build and see if it works?

[jwilberding]

Yep, I think so, let me try!

On Tue, Mar 4, 2014 at 9:54 AM, Chase James notifications@git.luolix.topwrote:

I think it failed because Travis didn't have an updated rebar. Latest
rebar should build it fine. Any way you can restart the build and see if it
works?

Reply to this email directly or view it on GitHubhttps://github.com//pull/128#issuecomment-36603617
.

[nuex]

Well, this didn't work out. I'm guessing Travis isn't using the latest rebar. It builds fine on my local machine. I got on Travis IRC and asked what version of rebar they are using.

Another possibility for checking the rebar version is to have make rebuild run "rebar --version" and allowing us to see the version in Travis's build results.

[nuex]

@jwilberding more updates on this. I told the folks on #travis my problem and they just realized their default rebar is from the basho/rebar repository.

They suggested we include a compiled rebar bin in the relx repo and travis will use that instead by default.

I personally prefer keeping bins out of the repo and in a directory loaded from $PATH. What do you think?

[nuex]

I was just informed that we could pull the rebar bin before building. Maybe call include get-rebar in the make rebuild step? Or possibly have a new make travis build task?

[nuex]

@jwilberding there's been some progress on this: https://github.com/travis-ci/travis-cookbooks/blob/master/ci_environment/rebar/attributes/default.rb

[jwilberding]

@Neux I will try kicking off the build again

[jwilberding]

@nuex Still failing :( I guess it may not be a bad idea to change the build script to automatically pull in rebar.

Do you have time to do that and submit a PR? It may be a day or two before I can do it.

[nuex]

@jwilberding: Sure!

[nuex]

@jwilberding Here is the PR: #134

[jwilberding]

@Neux Still failing for R16: https://travis-ci.org/erlware/relx/builds/20039654

[nuex]

@jwilberding I haven't rebased this against master yet. Should be able to get to it in an hour or so.

[nuex]

@jwilberding I'll work on this more later this afternoon.

[nuex]

@jwilberding well, it almost passed: https://travis-ci.org/erlware/relx/jobs/20315459

[nuex]

@jwilberding this may have been a glitch in the build. Would you mind restarting it to see if it happens again?

[jwilberding]

@nuex Still failing.. but I am not sure why.. do you have any ideas?

[nuex]

@jwilberding this is green now.

[tsloughter]

Wooo! @jwilberding I'll leave merging to you in case there is anything you wanted to verify :)

[jwilberding]

Thanks for working through that @nuex :)

[nuex]

yay!