Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files without empty line throws an error #1

Closed
PatrickJS opened this issue Jan 21, 2016 · 11 comments
Closed

files without empty line throws an error #1

PatrickJS opened this issue Jan 21, 2016 · 11 comments

Comments

@PatrickJS
Copy link

see PatrickJS/PatrickJS-starter#215 (comment) can you log a better error message to suggest having an empty new line

@erm0l0v
Copy link
Owner

erm0l0v commented Jan 21, 2016

Yes sure. I'll add error message.

@PatrickJS
Copy link
Author

thanks!

@dsebastien
Copy link
Contributor

+1, I'd like to see which file causes the issue as I'm left in the dark with the error

@jsec516
Copy link

jsec516 commented Feb 11, 2016

Is there any quick solve for that issue?

@PatrickJS
Copy link
Author

@erm0l0v more developers are running into this problem so it would be great to either show the file in question or allow files without the newline

@dsebastien
Copy link
Contributor

I'm looking at the code trying to reproduce the issue but I'm a bit lost ;-)

@dsebastien
Copy link
Contributor

I think I've got it. It's possible to pass an initialValue to the reduce function: http://es5.github.io/#x15.4.4.21

With it I think the issue will be fixed.

dsebastien added a commit to dsebastien/webpack-md5-hash that referenced this issue Feb 12, 2016
@dsebastien
Copy link
Contributor

I've created a PR for this: #2

erm0l0v added a commit that referenced this issue Feb 12, 2016
@erm0l0v
Copy link
Owner

erm0l0v commented Feb 12, 2016

Sorry for delay, guys.
@dsebastien thanks for PR.

I published version 0.0.5. Could you test this with your code?

@dsebastien
Copy link
Contributor

I've tested it against angular2-webpack-starter and it seems okay now, thanks!

@erm0l0v
Copy link
Owner

erm0l0v commented Feb 12, 2016

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants