chore(tslint): Add prettier-tslint rules, manually fix lint errors th…

…at don't have --fix

app/scripts/modules/amazon/src/loadBalancer/details/LoadBalancerActions.tsx

@@ -28,7 +28,7 @@ export class LoadBalancerActions extends React.Component<ILoadBalancerActionsPro
 
     const { app, loadBalancer } = this.props;
 
-    let application: Application = undefined;
+    let application: Application;
 
     const loadBalancerAppName = loadBalancer.name.split('-')[0];
     if (loadBalancerAppName === app.name) {

app/scripts/modules/amazon/src/reactShims/aws.ngReact.ts

@@ -9,28 +9,21 @@ import { ReactInject } from '@spinnaker/core';
 import { ScalingPolicyDetailsSummary } from 'amazon/serverGroup/details/scalingPolicy/detailsSummary.component';
 import { IScalingPolicySummaryProps } from 'amazon/serverGroup/details/scalingPolicy/ScalingPolicySummary';
 
+// prettier-ignore
 export class AwsNgReactInjector extends ReactInject {
   public $injectorProxy = {} as IInjectorService;
 
   // Reactified components
-  public ScalingPolicySummary: React.ComponentClass<IScalingPolicySummaryProps> = angular2react(
-    'scalingPolicySummary',
-    new ScalingPolicyDetailsSummary(),
-    this.$injectorProxy,
-  ) as any;
-  public SubnetSelectField: React.ComponentClass<ISubnetSelectFieldProps> = angular2react(
-    'subnetSelectFieldWrapper',
-    new SubnetSelectFieldWrapperComponent(),
-    this.$injectorProxy,
-  ) as any;
+  public ScalingPolicySummary: React.ComponentClass<IScalingPolicySummaryProps> = angular2react('scalingPolicySummary', new ScalingPolicyDetailsSummary(), this.$injectorProxy) as any;
+  public SubnetSelectField: React.ComponentClass<ISubnetSelectFieldProps>       = angular2react('subnetSelectFieldWrapper', new SubnetSelectFieldWrapperComponent(), this.$injectorProxy) as any;
 
   public initialize($injector: IInjectorService) {
     const realInjector: { [key: string]: Function } = $injector as any;
     const proxyInjector: { [key: string]: Function } = this.$injectorProxy as any;
 
     Object.keys($injector)
       .filter(key => typeof realInjector[key] === 'function')
-      .forEach(key => (proxyInjector[key] = realInjector[key].bind(realInjector)));
+      .forEach(key => proxyInjector[key] = realInjector[key].bind(realInjector));
   }
 }
 

app/scripts/modules/amazon/src/reactShims/aws.react.injector.ts

@@ -7,25 +7,15 @@ import { AwsServerGroupTransformer } from '../serverGroup/serverGroup.transforme
 import { AwsLoadBalancerTransformer } from '../loadBalancer/loadBalancer.transformer';
 import { VpcReader } from '../vpc/vpc.read.service';
 
+// prettier-ignore
 export class AwsReactInject extends ReactInject {
-  public get amazonCertificateReader() {
-    return this.$injector.get('amazonCertificateReader') as AmazonCertificateReader;
-  }
-  public get autoScalingProcessService() {
-    return this.$injector.get('autoScalingProcessService') as any;
-  }
-  public get awsLoadBalancerTransformer() {
-    return this.$injector.get('awsLoadBalancerTransformer') as AwsLoadBalancerTransformer;
-  }
-  public get awsServerGroupCommandBuilder() {
-    return this.$injector.get('awsServerGroupCommandBuilder') as any;
-  }
-  public get awsServerGroupTransformer() {
-    return this.$injector.get('awsServerGroupTransformer') as AwsServerGroupTransformer;
-  }
-  public get vpcReader() {
-    return this.$injector.get('vpcReader') as VpcReader;
-  }
+  public get amazonCertificateReader() { return this.$injector.get('amazonCertificateReader') as AmazonCertificateReader; }
+  public get autoScalingProcessService() { return this.$injector.get('autoScalingProcessService') as any; }
+  public get awsLoadBalancerTransformer() { return this.$injector.get('awsLoadBalancerTransformer') as AwsLoadBalancerTransformer; }
+  public get awsServerGroupCommandBuilder() { return this.$injector.get('awsServerGroupCommandBuilder') as any; }
+  public get awsServerGroupTransformer() { return this.$injector.get('awsServerGroupTransformer') as AwsServerGroupTransformer; }
+  public get vpcReader() { return this.$injector.get('vpcReader') as VpcReader; }
+
   public initialize($injector: IInjectorService) {
     this.$injector = $injector;
   }

app/scripts/modules/core/src/api/api.service.ts

@@ -5,7 +5,7 @@ import {
 } from '../authentication/authentication.initializer.service';
 import { SETTINGS } from 'core/config/settings';
 
-interface DefaultParams {
+interface IDefaultParams {
   timeout: number;
   headers: { [key: string]: string };
 }
@@ -26,7 +26,7 @@ export interface IRequestBuilder {
 
 export class Api {
   private gateUrl: string;
-  private defaultParams: DefaultParams;
+  private defaultParams: IDefaultParams;
 
   constructor(
     private $q: IQService,

app/scripts/modules/core/src/application/service/applicationDataSource.ts

@@ -122,7 +122,6 @@ export interface IDataSourceConfig {
    * (Optional) The application has potentially two default fields for each provider: region and credentials. These fields will
    * only have a value if every data source that contributes values has just one unique value for each provider. Useful
    * for setting initial values in modal dialogs when creating new server groups, load balancers, etc.
-
    * If the data source should contribute to the application's default region or credentials, this field should be set
    * to the field name that represents the provider on each data item.
    */

app/scripts/modules/core/src/cloudProvider/providerSelection/providerSelection.service.spec.ts

@@ -3,13 +3,11 @@ import { Application } from 'core/application/application.model';
 import { mock, IQService, IScope, IRootScopeService } from 'angular';
 import { IModalService } from 'angular-ui-bootstrap';
 
-import { ACCOUNT_SERVICE, AccountService } from 'core/account/account.service';
+import { ACCOUNT_SERVICE, AccountService, IAccountDetails } from 'core/account/account.service';
 import { CLOUD_PROVIDER_REGISTRY, CloudProviderRegistry } from 'core/cloudProvider/cloudProvider.registry';
 import { PROVIDER_SELECTION_SERVICE, ProviderSelectionService } from './providerSelection.service';
 import { SETTINGS } from 'core/config/settings';
 
-import { IAccountDetails } from 'core/account/account.service';
-
 function fakeAccount(provider: string): IAccountDetails {
   return {
     cloudProvider: provider,

app/scripts/modules/core/src/cloudProvider/providerSelection/providerSelection.service.ts

@@ -2,9 +2,7 @@ import { IModalService } from 'angular-ui-bootstrap';
 import { IPromise, module, IQService } from 'angular';
 import { uniq } from 'lodash';
 
-import { IAccountDetails } from 'core/account/account.service';
-
-import { ACCOUNT_SERVICE, AccountService } from 'core/account/account.service';
+import { IAccountDetails, ACCOUNT_SERVICE, AccountService } from 'core/account/account.service';
 import { Application } from 'core/application/application.model';
 import {
   CLOUD_PROVIDER_REGISTRY,

app/scripts/modules/core/src/diffs/commitHistory.component.ts

@@ -1,6 +1,4 @@
-import { module } from 'angular';
-
-import { IComponentOptions } from 'angular';
+import { module, IComponentOptions } from 'angular';
 
 export interface ICommit {
   authorDisplayName: string;

app/scripts/modules/core/src/diffs/viewChangesLink.component.ts

@@ -3,8 +3,7 @@ import { IController, IComponentOptions, module } from 'angular';
 import { IModalInstanceService, IModalService } from 'angular-ui-bootstrap';
 
 import { IBuildDiffInfo, ICreationMetadata, ICreationMetadataTag, IJenkinsInfo } from 'core/domain';
-import { ICommit } from './commitHistory.component';
-import { COMMIT_HISTORY_COMPONENT } from './commitHistory.component';
+import { ICommit, COMMIT_HISTORY_COMPONENT } from './commitHistory.component';
 import { EXECUTION_SERVICE, ExecutionService } from 'core/pipeline/service/execution.service';
 import { JAR_DIFF_COMPONENT, IJarDiff } from './jarDiff.component';
 

app/scripts/modules/core/src/domain/IJobConfig.ts

@@ -1,4 +1,4 @@
-export interface ParameterDefinitionList {
+export interface IParameterDefinitionList {
   defaultValue: string;
   description?: string;
   name: string;
@@ -10,6 +10,6 @@ export interface IJobConfig {
   description: string;
   displayName: string;
   name: string;
-  parameterDefinitionList: ParameterDefinitionList[];
+  parameterDefinitionList: IParameterDefinitionList[];
   url: string;
 }

app/scripts/modules/core/src/forms/numberList/numberList.component.spec.ts

@@ -1,13 +1,13 @@
 import { mock } from 'angular';
-import { NUMBER_LIST_COMPONENT, NumberListConstraints } from './numberList.component';
+import { NUMBER_LIST_COMPONENT, INumberListConstraints } from './numberList.component';
 
 describe('Component: numberList', () => {
   let $compile: ng.ICompileService,
     model: number[],
     stringModel: string,
     $scope: ng.IScope,
     elem: any,
-    constraints: NumberListConstraints,
+    constraints: INumberListConstraints,
     onChange: () => any;
 
   beforeEach(mock.module(NUMBER_LIST_COMPONENT));

app/scripts/modules/core/src/forms/numberList/numberList.component.ts

@@ -1,14 +1,14 @@
 import { IController, IComponentOptions, module } from 'angular';
 import './numberList.component.less';
 
-export interface NumberListConstraints {
+export interface INumberListConstraints {
   min: number;
   max: number;
 }
 
 export class NumberListController implements IController {
   public model: number[] | string;
-  public constraints: NumberListConstraints;
+  public constraints: INumberListConstraints;
   public label: string;
   public backingModel: number[];
   public parameterized: boolean;

app/scripts/modules/core/src/instance/instance.states.ts

@@ -1,9 +1,8 @@
 import { module } from 'angular';
 import { StateParams } from '@uirouter/angularjs';
 
-import { APPLICATION_STATE_PROVIDER, ApplicationStateProvider } from 'core/application';
+import { APPLICATION_STATE_PROVIDER, ApplicationStateProvider, Application } from 'core/application';
 import { INestedState, STATE_CONFIG_PROVIDER, StateConfigProvider } from 'core/navigation';
-import { Application } from 'core/application';
 import { SkinService } from 'core/cloudProvider';
 
 import { ApplicationModelBuilder } from '../application/applicationModel.builder';

app/scripts/modules/core/src/loadBalancer/filter/loadBalancer.filter.service.ts

@@ -1,8 +1,7 @@
 import { ILogService, module } from 'angular';
 import { chain, find, forOwn, groupBy, includes, intersection, map, some, sortBy, values, without } from 'lodash';
-import { Debounce } from 'lodash-decorators';
+import { Debounce, BindAll } from 'lodash-decorators';
 import { Subject } from 'rxjs';
-import { BindAll } from 'lodash-decorators';
 
 import { Application } from 'core/application/application.model';
 import { ILoadBalancer, ILoadBalancerGroup, IInstance, IServerGroup } from 'core/domain';

app/scripts/modules/core/src/modal/index.ts

@@ -4,8 +4,8 @@ export * from './wizard/WizardModal';
 export * from './wizard/WizardPage';
 export { V2_MODAL_WIZARD_COMPONENT, V2ModalWizard } from './wizard/v2modalWizard.component';
 export {
-  WizardPage,
+  IWizardPage,
   V2_MODAL_WIZARD_SERVICE,
   V2ModalWizardService,
-  WizardPageState,
+  IWizardPageState,
 } from './wizard/v2modalWizard.service';

app/scripts/modules/core/src/modal/wizard/v2modalWizard.service.ts

@@ -1,7 +1,7 @@
 import { module } from 'angular';
 import { SCROLL_TO_SERVICE, ScrollToService } from 'core/utils/scrollTo/scrollTo.service';
 
-export interface WizardPageState {
+export interface IWizardPageState {
   done: boolean;
   blocked: boolean;
   rendered: boolean;
@@ -11,16 +11,16 @@ export interface WizardPageState {
   required: boolean;
 }
 
-export interface WizardPage {
-  state: WizardPageState;
+export interface IWizardPage {
+  state: IWizardPageState;
   key: string;
   label: string;
 }
 
 export class V2ModalWizardService {
-  public renderedPages: WizardPage[] = [];
-  public pageRegistry: WizardPage[] = [];
-  public currentPage: WizardPage;
+  public renderedPages: IWizardPage[] = [];
+  public pageRegistry: IWizardPage[] = [];
+  public currentPage: IWizardPage;
   public heading: string;
 
   public constructor(private scrollToService: ScrollToService) {}
@@ -29,7 +29,7 @@ export class V2ModalWizardService {
     this.heading = heading;
   }
 
-  public getPage(key: string): WizardPage {
+  public getPage(key: string): IWizardPage {
     return this.pageRegistry.find(p => p.key === key);
   }
 
@@ -49,7 +49,7 @@ export class V2ModalWizardService {
     this.getPage(key).state.done = false;
   }
 
-  public setCurrentPage(page: WizardPage, skipScroll?: boolean): void {
+  public setCurrentPage(page: IWizardPage, skipScroll?: boolean): void {
     this.pageRegistry.forEach(test => (test.state.current = test === page));
     this.currentPage = page;
     this.markClean(page.key);
@@ -63,7 +63,7 @@ export class V2ModalWizardService {
     }
   }
 
-  public registerPage(key: string, label: string, state?: WizardPageState): void {
+  public registerPage(key: string, label: string, state?: IWizardPageState): void {
     state = state || {
       done: false,
       blocked: true,
@@ -78,7 +78,7 @@ export class V2ModalWizardService {
   }
 
   public renderPages(): void {
-    const renderedPages: WizardPage[] = this.pageRegistry.filter(page => page.state.rendered);
+    const renderedPages: IWizardPage[] = this.pageRegistry.filter(page => page.state.rendered);
     this.renderedPages = renderedPages;
     if (renderedPages.length === 1) {
       this.setCurrentPage(renderedPages[0]);

app/scripts/modules/core/src/modal/wizard/v2wizardPage.component.ts

@@ -16,7 +16,7 @@ import { V2_MODAL_WIZARD_SERVICE } from './v2modalWizard.service';
  *     scrolled into view
  */
 
-export interface WizardPageState {
+export interface IWizardPageState {
   rendered: boolean;
   done: boolean;
   dirty: boolean;
@@ -68,7 +68,7 @@ export class WizardPageController implements IController {
   /**
    * Internal state of the page, initialized based on other public fields
    */
-  public state: WizardPageState;
+  public state: IWizardPageState;
 
   public constructor(private $scope: ng.IScope, private v2modalWizardService: any) {
     'ngInject';

app/scripts/modules/core/src/navigation/urlBuilder.service.ts

@@ -42,7 +42,7 @@ interface IClusterFilter {
 }
 
 class UrlBuilderUtils {
-  private static forEachSorted(obj: any, iterator: Function, context: any = undefined): void {
+  private static forEachSorted(obj: any, iterator: Function, context?: any): void {
     const keys: string[] = Object.keys(obj).sort();
     keys.forEach((key: string) => {
       iterator.call(context, obj[key], key);

app/scripts/modules/core/src/pagerDuty/PageModal.tsx

@@ -1,7 +1,6 @@
 import { IDeferred } from 'angular';
 import { IModalServiceInstance } from 'angular-ui-bootstrap';
 import * as React from 'react';
-import { MouseEvent } from 'react';
 import { Button, Modal } from 'react-bootstrap';
 import { get } from 'lodash';
 import { BindAll } from 'lodash-decorators';
@@ -75,7 +74,7 @@ export class PageModal extends React.Component<IPageModalProps, IPageModalState>
     };
   }
 
-  public close(evt?: MouseEvent<any>): void {
+  public close(evt?: React.MouseEvent<any>): void {
     evt && evt.stopPropagation();
     this.setState(this.getDefaultState(this.props));
     this.props.closeCallback(false);