Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After adding a case-insensitive entry in accept.txt Vale does not validate other case-sensitive entries #727

Closed
1 task done
sohailekline opened this issue Nov 9, 2023 · 3 comments

Comments

@sohailekline
Copy link

Check for existing issues

  • Completed

Environment

OS: macOS
Install method: Homebrew
Vale Version: 2.29.6

Describe the bug / provide steps to reproduce it

I have added few entries in accept.txt (without ?i to make them case-sensitive/exact match), it works fine and Vale throws error if it's not exact match. However, when I am adding one more entry which is case-insensitive (like (?i)word), Vale stops throwing error on other exact-match entires.

Please have a look at following case:

accept.txt:

PLuG
(?i)GitHub

.vale.ini:

StylesPath = styles
MinAlertLevel = suggestion
Vocab = Base

[formats]
mdx = md

[*.md]
BasedOnStyles = Vale
Vale.Spelling = NO
Vale.Repetition = NO

README.md:

Plug
github
GitHub

The output of Vale is below. However, the expected output is it should give an error for Plug because it is not case-insensitive in accept.txt
image

Now, I have changed accept.txt as per below and it seems working fine:

PLuG
GitHub

The output of Vale is below.
image

##Observation

My observation is that if we define any case-insensitive entry all other entires become case-insensitive. This same issue is also found in reject.txt.

@puneet-ekline
Copy link

@jdkato Do you have any suggestions here?

jdkato added a commit that referenced this issue Nov 16, 2023
@jdkato
Copy link
Member

jdkato commented Nov 17, 2023

Should be fixed now.

@jdkato jdkato closed this as completed Nov 17, 2023
@sohailekline
Copy link
Author

@jdkato Thanks for providing the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants