This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Align with standard EKS bootstrap #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errm
force-pushed
the
align-with-standard-eks-bootstrap
branch
from
447d1c1
to
3469996
Compare
errm
force-pushed
the
align-with-standard-eks-bootstrap
branch
from
3469996
to
1aa22ef
Compare
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
=========================================
+ Coverage 87.03% 88.34% +1.3%
=========================================
Files 7 7
Lines 162 163 +1
=========================================
+ Hits 141 144 +3
+ Misses 13 12 -1
+ Partials 8 7 -1
Continue to review full report at Codecov.
|
Kubernetes is happy to search the path for the binary. I don't think it hurts to let this be installed wherever you want (on the path).
errm
force-pushed
the
align-with-standard-eks-bootstrap
branch
from
5344668
to
e7a0e8a
Compare
mtpereira
reviewed
Aug 30, 2018
mtpereira
approved these changes
Aug 30, 2018
errm
force-pushed
the
align-with-standard-eks-bootstrap
branch
from
fae3fb1
to
971d6bc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes:
Breaking change:
In line with https://github.com/awslabs/amazon-eks-ami the name of the binary for https://github.com/kubernetes-sigs/aws-iam-authenticator has changed from
/usr/local/bin/heptio-authenticator-awsto/usr/local/bin/aws-iam-authenticatorusers will need to rename, or symlink the binary... I could have maintained something special to check what it available on the system ... but this seems over the top....Nice Improvements: