Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Register spot nodes with different role #46

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Register spot nodes with different role #46

merged 1 commit into from
Nov 12, 2018

Conversation

errm
Copy link
Owner

@errm errm commented Nov 12, 2018

* Taint on-demand instances so we prefer spot instances
unless the node selector requires it, or there are no
spot instances avalible.

* Based on this https://github.com/pusher/k8s-spot-rescheduler#requirements
@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #46 into master will decrease coverage by 0.74%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #46      +/-   ##
=========================================
- Coverage   90.45%   89.7%   -0.75%     
=========================================
  Files           7       7              
  Lines         199     204       +5     
=========================================
+ Hits          180     183       +3     
- Misses         12      13       +1     
- Partials        7       8       +1
Impacted Files Coverage Δ
pkg/system/system.go 75% <0%> (-4.49%) ⬇️
pkg/node/node.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3752059...85e0e16. Read the comment docs.

@errm errm merged commit 6aa77c1 into master Nov 12, 2018
@errm errm deleted the spot-role branch November 12, 2018 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant