Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Migrate to go modules #51

Merged
merged 2 commits into from
Feb 26, 2019
Merged

Migrate to go modules #51

merged 2 commits into from
Feb 26, 2019

Conversation

errm
Copy link
Owner

@errm errm commented Jan 25, 2019

No description provided.

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   90.82%   90.82%           
=======================================
  Files           7        7           
  Lines         229      229           
=======================================
  Hits          208      208           
  Misses         13       13           
  Partials        8        8
Impacted Files Coverage Δ
pkg/file/atomic.go 76.92% <ø> (ø) ⬆️
pkg/eks/cluster.go 100% <100%> (ø) ⬆️
pkg/system/system.go 75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173d694...c51605a. Read the comment docs.

* Update dependencies
* Use latest go on travis
* Switch to golangci-linter
@@ -0,0 +1,13 @@
linters-settings:
lll:
line-length: 141
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, why 141 characters? 😆

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refuse to use shorter error messages to keep the line length short :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a way to split them in several lines, without too much hassle?

Copy link
Collaborator

@mtpereira mtpereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄 👍

@errm errm merged commit 5350109 into master Feb 26, 2019
@errm errm deleted the go-modules branch February 26, 2019 13:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants