Update node resources for new instance types #64
Conversation
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 7 7
Lines 255 255
=======================================
Hits 234 234
Misses 13 13
Partials 8 8 Continue to review full report at Codecov.
|
| @@ -29,7 +29,7 @@ var InstanceCores = map[string]int{ | |||
| "c3.xlarge": 4, | |||
| "c3.2xlarge": 8, | |||
| "c3.4xlarge": 16, | |||
| "c3.8xlarge": 32, | |||
There was a problem hiding this comment.
I think that 32 is the correct number of cores: https://ec2instances.info/?selected=c3.8xlarge
| @@ -43,13 +43,16 @@ var InstanceCores = map[string]int{ | |||
| "c5.12xlarge": 48, | |||
| "c5.18xlarge": 72, | |||
| "c5.24xlarge": 96, | |||
| "c5.metal": 96, | |||
There was a problem hiding this comment.
Same here: https://ec2instances.info/?selected=c5.metal
| @@ -82,7 +85,7 @@ var InstanceCores = map[string]int{ | |||
| "h1.4xlarge": 16, | |||
| "h1.8xlarge": 32, | |||
| "h1.16xlarge": 64, | |||
| "hs1.8xlarge": 17, | |||
There was a problem hiding this comment.
| @@ -430,7 +444,7 @@ var InstanceMemory = map[string]int{ | |||
| "m5n.24xlarge": 393216, | |||
| "p2.xlarge": 62464, | |||
| "p2.8xlarge": 499712, | |||
| "p2.16xlarge": 786432, | |||
There was a problem hiding this comment.
yeah it's quite weird ... the API docs basically say it could be wrong... and the service pricing page is canonical ... so 🤷♂ https://docs.aws.amazon.com/awsaccountbilling/latest/aboutv2/using-ppslong.html I guess it might be better to get these numbers from somewhere else ... |
No description provided.