Remove "engines" from package.json #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node will soon be releasing a new major version several times a year so the engines field is getting outdated quickly, and this project doesn't depend on many features of Node anyway. This commit is to make it so that downstream projects like react-native don't print a warning when people install it with io.js 3.0, Node.js 4.0, etc. To help catch issues, the Travis config file now tests the latest version of io.js. It also contains `sudo: false` so that it runs on Travis' new docker infrastructure: http://docs.travis-ci.com/user/workers/container-based-infrastructure/
|
I guess it isn't really needed anymore, because we have travis to test those versions. Do you require a version bump for this? |
Calamari
added a commit
that referenced
this pull request
Aug 19, 2015
Remove "engines" from package.json
|
@Calamari thanks for taking a look. Could you publish 0.1.3 to npm? |
|
Done. |
|
Thanks! |
|
You're welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node will soon be releasing a new major version several times a year so the engines field is getting outdated quickly, and this project doesn't depend on many features of Node anyway. This commit is to make it so that downstream projects like react-native don't print a warning when people install it with io.js 3.0, Node.js 4.0, etc.